Fix bugs with .dockerignore and improve integration test #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I improved handling of the .dockerignore file by: 1. Using docker's parser to parse the .dockerignore and using their helper functions to determine if a file should be deleted 2. Copying the Dockerfile we are building to /kaniko/Dockerfile so that if the Dockerfile is specified in .dockerignore it won't be deleted, and if it is specified in the .dockerignore it won't end up in the final image 3. I also improved the integration test to create a temp directory with files to ignore, and updated the .dockerignore to include exclusions (!)
priyawadhwa
force-pushed
the
dockerignore
branch
from
8a4b083
to
55e6157
Compare
sharifelgamal
approved these changes
Oct 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I improved handling of the .dockerignore file by:
helper functions to determine if a file should be deleted
if the Dockerfile is specified in .dockerignore it won't be deleted, and
if it is specified in the .dockerignore it won't end up in the final
image
files to ignore, and updated the .dockerignore to include exclusions (!)
Should fix #422