Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added --image-name-with-digest flag #841

Merged
merged 6 commits into from
Nov 8, 2019

Conversation

wripley
Copy link
Contributor

@wripley wripley commented Oct 29, 2019

Resolves #814.

Description
Added --image-name-with-digest to write image@sha256:... names based on destinations specified.

New flag will write a line for each destination specified. This is the full image path (ie, a docker registry will start with index.docker.io/{USER}/{IMAGE}@sha256:__)

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests

Release Notes

Added --image-name-with-digest flag
Description of flag: Specify a file to save the image name w/ digest of the built image to.

Copy link
Member

@tejal29 tejal29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. just 1 nit.

@tejal29 tejal29 merged commit 1d5e294 into GoogleContainerTools:master Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add --image-name-with-digest-file
3 participants