Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #925 broken insecure pull #932

Merged
merged 1 commit into from
Dec 23, 2019
Merged

Fix #925 broken insecure pull #932

merged 1 commit into from
Dec 23, 2019

Conversation

cvgw
Copy link
Contributor

@cvgw cvgw commented Dec 22, 2019

Fixes #925

Description

Fixes refactoring mistake which caused registry names to not update when insecure flags are provided

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

- Fix pull for insecure registries

@googlebot googlebot added the cla: yes CLA signed by all commit authors label Dec 22, 2019
@cvgw cvgw requested a review from tejal29 December 23, 2019 16:23
@tejal29 tejal29 merged commit eafb802 into GoogleContainerTools:master Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tejal29 tejal29 tejal29 approved these changes

Assignees
No one assigned
Labels
cla: yes CLA signed by all commit authors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pulling from insecure registry with skip tls verify fails with 0.15.0
3 participants
@cvgw @tejal29 @googlebot