-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various cleanups #4126
Merged
Merged
Various cleanups #4126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zac-HD
force-pushed
the
various-cleanups
branch
2 times, most recently
from
October 5, 2024 22:27
c63a72e
to
b090277
Compare
tybug
reviewed
Oct 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm otherwise 👍
Zac-HD
force-pushed
the
various-cleanups
branch
from
October 5, 2024 22:33
b090277
to
fa60b2a
Compare
Zac-HD
force-pushed
the
various-cleanups
branch
from
October 5, 2024 22:36
fa60b2a
to
f0385f8
Compare
Zac-HD
force-pushed
the
various-cleanups
branch
from
October 6, 2024 05:47
6216efe
to
4fc83cc
Compare
Zac-HD
force-pushed
the
various-cleanups
branch
from
October 6, 2024 06:01
4fc83cc
to
fa0d507
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The general theme here is trying to make it easier to review and hopefully merge other PRs by pulling out some easy stuff to shrink them.
Plus a performance improvement for stateful testing while I was looking at it, and more-compatible paths in patch headers.
Fixes #4116.