Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixrule(element_orientation_unlocked, img_alt_valid, aria_accessiblename_exists, img_alt_null): fix issues related to the rules #2011

Merged
merged 10 commits into from
Aug 29, 2024

Conversation

shunguoy
Copy link
Contributor

@shunguoy shunguoy commented Aug 26, 2024

  • Rule bug: element_orientation_unlocked, img_alt_valid, aria_accessiblename_exists

This PR is related to the following issue(s):

Testing reference:

I have conducted the following for this PR:

  • I validated this code in Chrome and FF
  • I validated this fix in my local env
  • I provided details for testing
  • This PR has been reviewed and is ready for test
  • I understand that the title of this PR will be used for the next release notes.

@shunguoy shunguoy changed the title fixrule(element_orientation_unlocked, img_alt_valid, aria_accessiblename_exists): fix issues related to the rules fixrule(element_orientation_unlocked, img_alt_valid, aria_accessiblename_exists, img_alt_null): fix issues related to the rules Aug 27, 2024
@shunguoy shunguoy marked this pull request as ready for review August 28, 2024 15:27
tombrunet
tombrunet previously approved these changes Aug 28, 2024
@tombrunet tombrunet dismissed their stale review August 28, 2024 16:44

Need to talk briefly

@philljenkins
Copy link
Contributor

@ErickRenteria Tom is OK with pushing out this PR, but @shunguoy
is trying one more time to recreate the Puppeteer fail/environment. We'll add the "Ready for QA" (or move this back to draft) when we're done

@philljenkins philljenkins removed their request for review August 29, 2024 16:20
@philljenkins
Copy link
Contributor

Opening new issue against version of Puppeteer (used in automated ACT testing). v13 does not handle the CSS correctly while v20 does. This PR should proceed to QA

@ErickRenteria ErickRenteria merged commit 596a948 into master Aug 29, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants