Update utils.py #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+183
to
+186
| xMin = min(pupilPixel[0]) # This is the left-most pixel of the pupil. | ||
| xMax = max(pupilPixel[0]) # This is the right-most pixel of the pupil. | ||
| yMin = min(pupilPixel[1]) # This is the upper-most pixel of the pupil. | ||
| yMax = max(pupilPixel[1]) # This is the lower-most pixel of the pupil. |
There was a problem hiding this comment.
Can you do the indexing pupilPixel[0][i] instead of min or max this makes it easier to understand what you are doing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the function to get the center of the pupils and the corresponding explanations