Deprecate IGListStackedSectionController
#1355
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
hanton
changed the title
IGListStackedSectionController
|
hi, in the CI tasks, the |
|
I was about to delete this guy too, glad that you are on it! thanks! |
There was a problem hiding this comment.
@lorixx has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Delete: * IGListStackedSectionController.h * IGListStackedSectionController.m * IGListStackedSectionControllerInternal.h * IGListReorderableStackSectionControllerTests.m * IGListStackSectionControllerTests.m * IGListTestAdapterStackedReorderingDataSource.h * IGListTestAdapterStackedReorderingDataSource.m * IGTestStackedDataSource.h * IGTestStackedDataSource.m Update: * IGListKit.h * IGListAdapterStoryboardTests.m
Delete: * PrefixedLabelSectionController.swift * ReorderableStackedViewController.swift * StackedViewController.swift Update: * DemosViewController.swift
hanton
force-pushed
the
remove_IGListStackedSectionController
branch
from
bcc13a1
to
b3be355
Compare
|
@hanton has updated the pull request. Re-import the pull request |
|
hi @lorixx , the PR is rebased to the latest |
There was a problem hiding this comment.
@lorixx has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Ziewvater
pushed a commit
to Ziewvater/IGListKit
that referenced
this pull request
Oct 22, 2019
Summary: Our [builds](https://travis-ci.org/Instagram/IGListKit) have been failing since `IGListStackedSectionController` was removed in [D17200801](D17200801)/[1355](Instagram#1355). The error message in our Travis logs points to something related to `IGListStackedSectionController` causing the error: ``` X error: /Users/travis/build/Instagram/IGListKit/Source/Internal/IGListStackedSectionControllerInternal.h: No such file or directory ** BUILD FAILED ** The following build commands failed: CpHeader /Users/travis/build/Instagram/IGListKit/Source/Internal/IGListStackedSectionControllerInternal.h /Users/travis/Library/Developer/Xcode/DerivedData/IGListKitExamples-cfbxdbnpimeeplcoaiqrlyrrqjxn/Build/Products/Debug-iphonesimulator/IGListKit/IGListKit.framework/PrivateHeaders/IGListStackedSectionControllerInternal.h (1 failure) ``` Pretty sure the issue here is that the `xcodeproj` files were not rebuilt after deleting these files, which meant they were pointing to files that no longer existed, which caused the build to fail. I was able to fix this issue by running our `setup.sh` script, which regenerated the `xcodeproj` files. Reviewed By: bdotdub Differential Revision: D18064465 fbshipit-source-id: 3351c83255d7e4247efd0a00f7ced8372ac34548
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 23, 2019
Summary: Pull Request resolved: #1376 Our [builds](https://travis-ci.org/Instagram/IGListKit) have been failing since `IGListStackedSectionController` was removed in [D17200801](D17200801)/[1355](#1355). The error message in our Travis logs points to something related to `IGListStackedSectionController` causing the error: ``` X error: /Users/travis/build/Instagram/IGListKit/Source/Internal/IGListStackedSectionControllerInternal.h: No such file or directory ** BUILD FAILED ** The following build commands failed: CpHeader /Users/travis/build/Instagram/IGListKit/Source/Internal/IGListStackedSectionControllerInternal.h /Users/travis/Library/Developer/Xcode/DerivedData/IGListKitExamples-cfbxdbnpimeeplcoaiqrlyrrqjxn/Build/Products/Debug-iphonesimulator/IGListKit/IGListKit.framework/PrivateHeaders/IGListStackedSectionControllerInternal.h (1 failure) ``` Pretty sure the issue here is that the `xcodeproj` files were not rebuilt after deleting these files, which meant they were pointing to files that no longer existed, which caused the build to fail. I was able to fix this issue by running our `setup.sh` script, which regenerated the `xcodeproj` files. Reviewed By: bdotdub Differential Revision: D18064465 fbshipit-source-id: d07586a99d4bbb9346bdda0752dbd613eb1b6d03
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Issue fixed: #1099
Checklist
CHANGELOG.mdfor any breaking changes, enhancements, or bug fixes.