use cocoapods cdn #1386
Closed
use cocoapods cdn #1386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koenpunt
force-pushed
the
use-cocoapods-cdn
branch
from
8c8d688
to
f2e242c
Compare
Generated by 🚫 Danger |
There was a problem hiding this comment.
@iperry90 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
lorixx
reviewed
Nov 18, 2019
| @@ -94,7 +94,7 @@ install_dsym() { | |||
| binary="${DERIVED_FILES_DIR}/${basename}.framework.dSYM/Contents/Resources/DWARF/${basename}" | |||
|
|
|||
| # Strip invalid architectures so "fat" simulator / device frameworks work on device | |||
| if [[ "$(file "$binary")" == *"Mach-O dSYM companion"* ]]; then | |||
| if [[ "$(file "$binary")" == *"Mach-O "*"dSYM companion"* ]]; then | |||
There was a problem hiding this comment.
What's the reason for all these script changes?
There was a problem hiding this comment.
Since these are generated I guess that's because of the CocoaPods update.
There was a problem hiding this comment.
Well, I'm not guessing, I know for sure.
There was a problem hiding this comment.
gotcha, so it's Pod generated script, looks good to me then!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
This updates the Podfile to use the specs CDN instead of the git checkout, which is more performant (and the default with CocoaPods 1.8 and higher).
Checklist
CHANGELOG.mdfor any breaking changes, enhancements, or bug fixes.