-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve SwiftPM support #1546
Closed
Closed
Improve SwiftPM support #1546
Commits on Oct 15, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 3e13bf9 - Browse repository at this point
Copy the full SHA 3e13bf9View commit details
Commits on Dec 7, 2021
-
Handle cases where the delegate is already an IGListAdapter
Summary: I was assuming the delegate would always be an IGListAdapterProxy, but this only happens if the client sets either the `collectionViewDelegate` or `scrollViewDelegate` properties on IGListAdapter. Otherwise the delegate will just be the IGListAdapter. Change the debug code to handle this case. We were starting to see some debug logs roll in with the delegate class listed as IGListAdapter. Hopefully this will return the correct class now. Differential Revision: D31690438 fbshipit-source-id: bf6dde57756fee4fe617944d45e152cae734b4f1
Configuration menu - View commit details
-
Copy full SHA for 324aea4 - Browse repository at this point
Copy the full SHA 324aea4View commit details -
Summary: As title, currently https://instagram.github.io/IGListKit/ is not working. Let's try to rebuild the doc Reviewed By: Ziewvater Differential Revision: D31811862 fbshipit-source-id: 8a0b0ce6c73542da71dddd13c24b5eb9fe9b0506
Configuration menu - View commit details
-
Copy full SHA for 5892c34 - Browse repository at this point
Copy the full SHA 5892c34View commit details -
Get index path or scroll position of first visible item in list (Inst…
…agram#1544) Summary: Pull Request resolved: Instagram#1544 Refactored and added functions to IGListAdapter for getting index path or scroll position of first visible item in list. This makes it possible to see which item is the current first visible item scrolled to in the list, and determine how far it is scrolled into (analogous to additionalOffset in scrollToObject:). Reviewed By: lorixx Differential Revision: D32196398 fbshipit-source-id: d809d5f96bb4e1d95055dbebe4e55c1a428a40ed
Configuration menu - View commit details
-
Copy full SHA for f47a17c - Browse repository at this point
Copy the full SHA f47a17cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 672897a - Browse repository at this point
Copy the full SHA 672897aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 65c31b8 - Browse repository at this point
Copy the full SHA 65c31b8View commit details
Commits on Dec 8, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 07b2d78 - Browse repository at this point
Copy the full SHA 07b2d78View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6d17b70 - Browse repository at this point
Copy the full SHA 6d17b70View commit details -
Configuration menu - View commit details
-
Copy full SHA for e59deb2 - Browse repository at this point
Copy the full SHA e59deb2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 77030b4 - Browse repository at this point
Copy the full SHA 77030b4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 488b83f - Browse repository at this point
Copy the full SHA 488b83fView commit details -
Configuration menu - View commit details
-
Copy full SHA for fed49da - Browse repository at this point
Copy the full SHA fed49daView commit details -
Configuration menu - View commit details
-
Copy full SHA for 90c4804 - Browse repository at this point
Copy the full SHA 90c4804View commit details
Commits on Dec 9, 2021
-
Configuration menu - View commit details
-
Copy full SHA for a00f926 - Browse repository at this point
Copy the full SHA a00f926View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1d9fba7 - Browse repository at this point
Copy the full SHA 1d9fba7View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.