Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove IGListGridCollectionViewLayout #482

Closed
wants to merge 2 commits into from
Closed

Remove IGListGridCollectionViewLayout #482

wants to merge 2 commits into from

Conversation

rnystrom
Copy link
Contributor

Changes in this pull request

Follow from #450, this layout has been replaced. You served us well!

Pull request checklist

  • All tests pass. Demo project builds and runs.
  • I added an entry to the CHANGELOG.md for any breaking changes, enhancements, or bug fixes.

@Sherlouk
Copy link
Contributor

😢 Emotional times!

Other than a name change, is the new layout essentially like for like?

@zhubofei
Copy link

@rnystrom we need to remove/modify the examples that use grid layout as well.

@facebook-github-bot
Copy link
Contributor

@rnystrom updated the pull request - view changes

@rnystrom
Copy link
Contributor Author

Demo isn't totally the same as previous layout, but just about there. We don't have IBInspectable properties yet, but we can add those next.

simulator screen shot feb 10 2017 8 23 35 pm

@facebook-github-bot
Copy link
Contributor

@rnystrom updated the pull request - view changes

@zhubofei
Copy link

👍👍👍

@facebook-github-bot
Copy link
Contributor

@rnystrom has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants