Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IGListAdapter support for scrollViewDidEndDecelerating #899

Closed
wants to merge 12 commits into from
Closed

IGListAdapter support for scrollViewDidEndDecelerating #899

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
a85956a
IGListAdapter support for scrollViewDidEndDecelerating
plarson Aug 15, 2017
c612abf
Merge branch 'master' of github.com:Instagram/IGListKit into decelera…
plarson Aug 15, 2017
b330ff4
Add CHANGELOG entry for scrollViewDidEndDecelerating
plarson Aug 15, 2017
be9a0a2
Make -[IGListScrollDelegate listAdapter:didEndDeceleratingSectionCont…
plarson Aug 19, 2017
0d99c26
Update IGListScrollDelegate.h
rnystrom Aug 21, 2017
2033efc
Merge branch 'master' of github.com:Instagram/IGListKit into decelera…
plarson Aug 22, 2017
f103dfd
Add Swift name for -[IGListScrollDelegate listAdapter:didEndDecelerat…
plarson Aug 22, 2017
6e7e7ee
Add test for -[IGListScrollDelegate listAdapter:didEndDeceleratingSec…
plarson Aug 22, 2017
9776139
Merge branch 'deceleration' of github.com:unmute/IGListKit into decel…
plarson Aug 22, 2017
5355126
Add another test for scrollViewDidEndDecelerating
plarson Aug 22, 2017
98b49bd
Update IGListAdapter.m
rnystrom Aug 23, 2017
fa5ece6
Update IGListStackedSectionController.m
rnystrom Aug 23, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Source/IGListScrollDelegate.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ NS_SWIFT_NAME(ListScrollDelegate)
@note This method is `@optional` until the next breaking-change release.
*/
@optional
- (void)listAdapter:(IGListAdapter *)listAdapter didEndDeceleratingSectionController:(IGListSectionController *)sectionController;
- (void)listAdapter:(IGListAdapter *)listAdapter didEndDeceleratingSectionController:(IGListSectionController *)sectionController NS_SWIFT_NAME(listAdapter(_:didEndDecelerating:));

@end

Expand Down
28 changes: 28 additions & 0 deletions Tests/IGListStackSectionControllerTests.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -693,6 +693,34 @@ - (void)test_whenForwardingDidEndDraggingEvent_thatChildSectionControllersReceiv
[mockScrollDelegate verify];
}

- (void)test_whenForwardingDidEndDeceleratingEvent_thatChildSectionControllersReceiveEvent {
[self setupWithObjects:@[
[[IGTestObject alloc] initWithKey:@0 value:@[@1, @2, @3]],
[[IGTestObject alloc] initWithKey:@2 value:@[@1, @1]]
]];

id mockScrollDelegate = [OCMockObject mockForProtocol:@protocol(IGListScrollDelegate)];

IGListStackedSectionController *stack0 = [self.adapter sectionControllerForObject:self.dataSource.objects[0]];
IGListStackedSectionController *stack1 = [self.adapter sectionControllerForObject:self.dataSource.objects[1]];

[stack0.sectionControllers[0] setScrollDelegate:mockScrollDelegate];
[stack0.sectionControllers[1] setScrollDelegate:mockScrollDelegate];
[stack0.sectionControllers[2] setScrollDelegate:mockScrollDelegate];
[stack1.sectionControllers[0] setScrollDelegate:mockScrollDelegate];
[stack1.sectionControllers[1] setScrollDelegate:mockScrollDelegate];

[[mockScrollDelegate expect] listAdapter:self.adapter didEndDeceleratingSectionController:stack0.sectionControllers[0]];
[[mockScrollDelegate expect] listAdapter:self.adapter didEndDeceleratingSectionController:stack0.sectionControllers[1]];
[[mockScrollDelegate expect] listAdapter:self.adapter didEndDeceleratingSectionController:stack0.sectionControllers[2]];
[[mockScrollDelegate expect] listAdapter:self.adapter didEndDeceleratingSectionController:stack1.sectionControllers[0]];
[[mockScrollDelegate expect] listAdapter:self.adapter didEndDeceleratingSectionController:stack1.sectionControllers[1]];

[self.adapter scrollViewDidEndDecelerating:self.collectionView];

[mockScrollDelegate verify];
}

- (void)test_whenUsingSupplementary_withCode_thatSupplementaryViewExists {
// updater that uses reloadData so we can rebuild all views/sizes
IGListAdapter *adapter = [[IGListAdapter alloc] initWithUpdater:[IGListReloadDataUpdater new] viewController:nil];
Expand Down