Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add build success step #175

Merged
merged 7 commits into from
Jul 8, 2024
Merged

add build success step #175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
59fbf15
add build success step
ttstarck Jul 2, 2024
41c6c87
non-production: Update Appraisal Gemfiles
octothorpe Jul 2, 2024
f59099f
remove push from webhook actions
ttstarck Jul 3, 2024
c4cf2ff
fix sqlite
ttstarck Jul 3, 2024
5cbbb72
fix appraisal gemfiles
ttstarck Jul 3, 2024
3bea78e
use all-green action
ttstarck Jul 8, 2024
0c5b9a5
remove Update Appraisals workflow
ttstarck Jul 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/workflows/pipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,3 +25,13 @@ jobs:
bundler-cache: true
- run: bundle exec rails db:migrate
- run: bundle exec rake test
build_success:
if: always()
needs:
- tests
runs-on: Ubuntu-latest
steps:
- name: Decide whether the needed jobs succeeded or failed
uses: re-actors/alls-green@release/v1
with:
jobs: ${{ toJSON(needs) }}
24 changes: 0 additions & 24 deletions .github/workflows/update_appraisals.yml
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@ gem 'pry'
gem 'rr', '3.1.0'
gem 'rubocop', require: false
gem 'shoulda'
gem 'sqlite3', "~> 2.0"
gem 'sqlite3', "~> 1.4"
Copy link
Contributor Author

@ttstarck ttstarck Jul 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Multiple Rails versions require sqlite3 1.x, so I've set this in the gemfile.

gem 'test-unit', '3.6.2'
gem 'test_after_commit', require: false
4 changes: 2 additions & 2 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ GEM
shoulda-context (2.0.0)
shoulda-matchers (4.5.1)
activesupport (>= 4.2.0)
sqlite3 (2.0.2)
sqlite3 (1.7.3)
mini_portile2 (~> 2.8.0)
stringio (3.1.1)
strscan (3.1.0)
Expand Down Expand Up @@ -266,7 +266,7 @@ DEPENDENCIES
rr (= 3.1.0)
rubocop
shoulda
sqlite3 (~> 2.0)
sqlite3 (~> 1.4)
test-unit (= 3.6.2)
test_after_commit

Expand Down
4 changes: 2 additions & 2 deletions gemfiles/activerecord_6_0.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@ gem "jquery-rails"
gem "minitest", "~> 5.1"
gem "minitest-reporters"
gem "pry"
gem "rr", "1.1.2"
gem "rr", "3.1.0"
gem "rubocop", require: false
gem "shoulda"
gem "sqlite3", "~> 2.0"
gem "sqlite3", "~> 1.4"
gem "test-unit", "3.6.2"
gem "test_after_commit", require: false
gem "activerecord", "~> 6.0.0"
Expand Down
4 changes: 2 additions & 2 deletions gemfiles/activerecord_6_1.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@ gem "jquery-rails"
gem "minitest", "~> 5.1"
gem "minitest-reporters"
gem "pry"
gem "rr", "1.1.2"
gem "rr", "3.1.0"
gem "rubocop", require: false
gem "shoulda"
gem "sqlite3", "~> 2.0"
gem "sqlite3", "~> 1.4"
gem "test-unit", "3.6.2"
gem "test_after_commit", require: false
gem "activerecord", "~> 6.1.0"
Expand Down
4 changes: 2 additions & 2 deletions gemfiles/activerecord_7_0.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@ gem "jquery-rails"
gem "minitest", "~> 5.1"
gem "minitest-reporters"
gem "pry"
gem "rr", "1.1.2"
gem "rr", "3.1.0"
gem "rubocop", require: false
gem "shoulda"
gem "sqlite3", "~> 2.0"
gem "sqlite3", "~> 1.4"
gem "test-unit", "3.6.2"
gem "test_after_commit", require: false
gem "activerecord", "~> 7.0.0"
Expand Down
4 changes: 2 additions & 2 deletions gemfiles/activerecord_7_1.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@ gem "jquery-rails"
gem "minitest", "~> 5.1"
gem "minitest-reporters"
gem "pry"
gem "rr", "1.1.2"
gem "rr", "3.1.0"
gem "rubocop", require: false
gem "shoulda"
gem "sqlite3", "~> 2.0"
gem "sqlite3", "~> 1.4"
gem "test-unit", "3.6.2"
gem "test_after_commit", require: false
gem "activerecord", "~> 7.1.0"
Expand Down
Loading