Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newspaper Issues Calendar View #91

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

amym-li
Copy link

@amym-li amym-li commented Jun 7, 2023

This PR installs the fullcalendar_solr module and provides a calendar view for newspaper collections.

It includes:

  • A year calendar view configured with Advanced Search and Facet blocks. The year calendar highlights dates containing newspaper issues for the specified year. When a highlighted date is clicked, it opens a tab to the day view and preserves the search keys and facets.

image

  • A day view configured with Advanced Search and Facet blocks. The day view displays newspaper issues for a specified date. (Modelled after the Solr search content view)
  • A block that generates a link to the calendar view, added to the Newspapers display context. It sets the calendar year to the oldest year with results but this can be modified by editing the sort criteria for the Calendar Link block.

image

@rosiel
Copy link
Contributor

rosiel commented Jun 13, 2023

Once we add this (this pr's ok, i'll make a follow-up) we can remove views nested details, right?

@rosiel
Copy link
Contributor

rosiel commented Jun 14, 2023

Accessibility testing?

@rosiel
Copy link
Contributor

rosiel commented Jun 15, 2023

1 - my test with voiceover found it impossible to access the individual days, unless you tab across each date, and even in that case, the coloured highlighting is inaudible.

There are more tweaks i'd propose - including making this the default newspaper view or available in an alternate rendering while keeping the same breadcrumbs - but the accessibility piece is the big one.

@amym-li amym-li closed this Jun 17, 2023
@amym-li amym-li force-pushed the fullcalendar_solr branch 2 times, most recently from 01741d7 to 579d80a Compare June 17, 2023 04:10
Upgrade fullcalendar_solr version to 1.0.0-beta6
@amym-li amym-li reopened this Jun 17, 2023
@amym-li
Copy link
Author

amym-li commented Jun 17, 2023

An update on the accessibility issues, I've updated the PR to use the latest release of the FullCalendar Solr module.

This version has improved accessibility:

  • Only highlighted dates are tabbable
  • Highlighted dates have more descriptive aria labels

Accessibility testing was done using WebAIM WAVE and Axe DevTools.

In addition to the accessibility improvements, there is an added option to link to the item if the date has only one result.

@rosiel
Copy link
Contributor

rosiel commented Jun 19, 2023

Great. I noticed you're using the Date Created field. In the other newspaper view, we use Date Issued (which is also what the sample content has).

@amym-li
Copy link
Author

amym-li commented Jun 20, 2023

The calendar view now uses the Date Issued field instead of Date Created.
Also, the day view takes the date as a contextual filter so I had to add the Date Issued field to the Search API Index.

Changes:
- Calendar Link block redirects to the latest year with results
- Enable option to link to option if date has only one result
@amym-li
Copy link
Author

amym-li commented Jun 21, 2023

I updated the Calendar Link block to redirect to the latest year with results. Also, enabled the option to link directly to the issue if a date has only one result.

@amym-li
Copy link
Author

amym-li commented Jun 23, 2023

An update on breadcrumbs:

The Newspaper node can be added to the breadcrumbs on the Calendar View by enabling the Include the current node in the breadcrumbs? option. However, this will affect how all other breadcrumbs are displayed as well.

image


When disabled:
image


When enabled:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants