Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Default Log Levels for Containers to Warning or Error? #217

Closed
misilot opened this issue May 17, 2022 · 6 comments
Closed

Set Default Log Levels for Containers to Warning or Error? #217

misilot opened this issue May 17, 2022 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@misilot
Copy link
Contributor

misilot commented May 17, 2022

Can the default log levels be set to warning or error, with the option to override them via ENV variables?

cantaloupe is outputting at least DEBUG logs
fits is outputting at least INFO logs
activemq is outputting INFO as well
...

@nigelgbanks
Copy link
Contributor

All logging levels should be override-able via the environment variables noted in the images README, or in the case of their parent images README for things that use some services like nginx or tomcat. The defaults thus far have been what was shipped as defaults from each of the tools we're using.

That being said choosing one level and using it everywhere sounds reasonable to me. I'd tend to go with INFO everywhere in such a case though. It would make it easier for people using the defaults to provide information in their tickets, but still isn't as overwhelming as DEBUG.

@g7morris and @jefferya do you want to weigh in with a preference?

@jefferya
Copy link
Contributor

I think the default level should be targeted to a specific use-case. I see ERROR/WARN defaults targeting a production or user who doesn't want/need logs. Or INFO/DEBUG targeting testers/developers trying to troubleshoot. INFO everywhere for the reason Nigel mentions has merit in my opinion however, I don't have a strong opinion.

@misilot
Copy link
Contributor Author

misilot commented May 18, 2022

My vote would be for production level expectations for logs, open ports, etc...

Especially since ISLE is almost a "click to run" application, in which people could just stand this up and assume, yup everything is working, and put content in, and call it good.

Having a way to easily override the log levels which it seems like it does, through the environment variables for development / troubleshooting purposes, and maybe that needs to be addressed in documentation

@g7morris
Copy link
Contributor

Late to the party. The ability to change the levels via confd or variables is the key feature here.

With respect to preferences, I'm with @nigelgbanks INFO should always be default as a rote level of debugging is typically needed though I also agree with @misilot on Prod system needs being more conservative and less verbose so see point #1 above ;)

@g7morris
Copy link
Contributor

g7morris commented Aug 4, 2022

Okay the following services have been bumped up one level from debug to a less talkative info

  • crayfits
  • homarus
  • houdini
  • hypercube
  • milliner
  • recast
  • riprap

All other services were set to the following notice, error or warn which in our opinion were sufficient or optimal given their function e.g. confd or php errors aren't typically read

@nigelgbanks
Copy link
Contributor

This has been rolled out in release 1.0.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants