Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 174 - Logging #206

Merged
merged 12 commits into from
May 2, 2022
Merged

Issue 174 - Logging #206

merged 12 commits into from
May 2, 2022

Conversation

nigelgbanks
Copy link
Contributor

@nigelgbanks nigelgbanks commented Apr 11, 2022

For Issue-174 this removes the use of symlinks and instead appropriately configures the logging for each service using the recommend methods according to their documentation.

There is one notable exception handle still uses symlinks to get the services to write to stdout/stderr as there is no other method possible in its cases as the logging is hard coded in the application to write to specific files at specific path.

@nigelgbanks
Copy link
Contributor Author

Lost some time debugging failing tests on my M1 Macbook, need to upgrade Gradle when the next release is minted to get
gradle/gradle@9059e16 currently we cannot perform tests on M1.

@nigelgbanks
Copy link
Contributor Author

The failing test is caused by an odd karaf behaviour in that when it first starts up it writes to karaf.log before the loggers are configured so the first few lines of output go there. The tests is looking for these lines and timing out.

@nigelgbanks nigelgbanks marked this pull request as draft April 11, 2022 13:41
@nigelgbanks
Copy link
Contributor Author

nigelgbanks commented Apr 11, 2022

God that was hard to debug for 88f7aa6 at least now I know how to use jdb.

This is now ready for review.

@nigelgbanks nigelgbanks marked this pull request as ready for review April 11, 2022 14:21
@rosiel
Copy link
Contributor

rosiel commented Apr 13, 2022

From tech call: is it possible to get some testing instructions?

@nigelgbanks
Copy link
Contributor Author

Broadly speaking to test, is that it works and logs are generated to standard out.

@nigelgbanks nigelgbanks changed the title Issue 174 Issue 174 - Logging Apr 19, 2022
@g7morris
Copy link
Contributor

g7morris commented Apr 28, 2022

Hi @rosiel

Great question, apologies for the late reply.

Hopefully my response below could be copied to isle-dc documentation or to a different location that works for folks in addition to this location? If not, no worries we'll at least have this process captured in this repo.

I've made a new PR for this process if you have time to review #212

Happy to help as needed here.

@nigelgbanks Feel free to add anything I may have missed.

[Edit] I originally posted everything here as a response and realized it should just be a draft doc to work on instead. Sorry for the dump folks.

Thanks,
Gavin

@g7morris
Copy link
Contributor

Tested and this passes as noted here #174

@nigelgbanks Ship it.

@nigelgbanks nigelgbanks merged commit 7ecc484 into main May 2, 2022
@nigelgbanks nigelgbanks deleted the issue-174 branch May 12, 2022 11:25
@nigelgbanks nigelgbanks restored the issue-174 branch May 12, 2022 11:25
@nigelgbanks nigelgbanks deleted the issue-174 branch May 12, 2022 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants