pass event type as event header to milliner #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #61 +/- ##
============================================
+ Coverage 84.89% 85.33% +0.44%
- Complexity 96 98 +2
============================================
Files 16 16
Lines 331 341 +10
Branches 1 1
============================================
+ Hits 281 291 +10
Misses 49 49
Partials 1 1
Continue to review full report at Codecov.
|
|
I will work on tests once I know if this is the right approach to take. |
|
I'm going to try to update the tests for this as well |
…en isNewVersion is 1
… to both happen - very noisily
|
This appears to work for me. 👍 The one hiccup I have is that the derivative consumers aren't starting up. |
|
Ah, I bet I need to update the AS2Object in the connector-derivative also |
|
Are you seeing any kind of error message on the derivs? I'm not seeing anything errors in the karaf.log |
|
When installing the derivative connector the karaf client didn't complain but there is a lot of activity in the logs. E.g.: I didn't know about these messages until the derivatives failed to appear. The derivative messages don't show up in the karaf log because the consumer failed to start and didn't dequeued them from ActiveMQ: |
|
It’s alllllliiiiiiiive! 🥳 |
seth-shaw-unlv
approved these changes
Nov 7, 2019
(after Travis comes back okay).
|
...and Travis hates my whitespace. Good to know big brother is still watching. I'll undo that whitespace then. |
|
Well, at least Travis is happy now! @elizoller, we just need to get codecov happy now. |
|
ok, no problem. i'll look at the tests. thank you so much @seth-shaw-unlv! |
|
The more I look at this, the more I think that we don't need to touch the AS2Object in the derivative-connector. Because the derivative-connector doesn't need to know if its a new Drupal version, right? |
|
@elizoller, you are probably right. Wasn't that added when we were trying to figure out why my derivatives weren't processing? We can try pulling it out and seeing if it still works without it. |
|
If I remove it from the AS2Object for the derivative-connector here in Alpaca then the related PR for Islandora will have to not send the isNewVersion flag to anything that goes to islandora-connector-* queues instead of islandora-indexing-fcrepo (or else it'll error). So it'll involve a commit here and corresponding commit on the islandora PR Islandora/islandora#733 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: (Islandora/documentation#740)
What does this Pull Request do?
Passes the event type through from the Drupal event object to Milliner's node stream
What's new?
just mapping event.object.type to a header called Event
How should this be tested?
Additional Notes:
I kind of made up this header. There are many different ways to do this. It could be an entirely separate stream of events from drupal and/or it could point to a separate milliner endpoint. I'm definitely open to whatever is deemed as the best practice - this was just a starting point to get the pieces connected.
Interested parties
@Islandora-CLAW/committers