Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow filehash 3 #1016

Merged
merged 1 commit into from
May 1, 2024
Merged

Allow filehash 3 #1016

merged 1 commit into from
May 1, 2024

Conversation

rosiel
Copy link
Member

@rosiel rosiel commented Apr 29, 2024

GitHub Issue: #1005

I've tested this and Islandora's code still runs without errors.

  • Other Relevant Links

The DGI Fixity module still requires 2.x so we're keeping it in here (also makes it compatible with Drupal < 10.2)

What does this Pull Request do?

Allows Filehash 3

What's new?

  • Allows Filehash 3
  • Does this change add any new dependencies? No
  • Does this change require any other modifications to be made to the repository
    (i.e. Regeneration activity, etc.)? no
  • Could this change impact execution of existing code? potentially! But my testing showed behaviour stays the same.

How should this be tested?

Put a breakpoint around https://github.com/Islandora/islandora/blob/2.x/islandora.module#L186 and see that you can still access those "fields" on the file entity, and that they return the appropriate checksums.

Also I noted that as before, if you look at the Content > Files list (and edit the view to add Original SHA-1 and SHA-1), any media created by derivatives has a null Original SHA-1.

Documentation Status

  • Does this change existing behaviour that's currently documented? no
  • Does this change require new pages or sections of documentation? no
  • Who does this need to be documented for? no
  • Associated documentation pull request(s): ___ or documentation issue ___

Additional Notes:

Any additional information that you think would be helpful when reviewing this
PR.

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora/committers

Copy link
Member

@seth-shaw-asu seth-shaw-asu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@seth-shaw-asu seth-shaw-asu merged commit 3902cce into 2.x May 1, 2024
24 checks passed
@seth-shaw-asu seth-shaw-asu deleted the rosiel-filehash branch May 1, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants