The "Node has ancestor" condition shouldn't be required

[simonhm]

GitHub Issue: (link)

• Other Relevant Links (Google Groups discussion, related pull requests,
  Release pull requests, etc.)

(#865 (comment))

What does this Pull Request do?

Make the "Node has ancestor" to be "not required".

What's new?

A in-depth description of the changes made by this PR. Technical details and
possible side effects.

• Changes x feature to such that y
• Added x
• Removed y
• Does this change add any new dependencies?
• Does this change require any other modifications to be made to the repository
  (i.e. Regeneration activity, etc.)?
• Could this change impact execution of existing code?

How should this be tested?

Place a block without filling the "Node has ancestor" condition.

Documentation Status

• Does this change existing behaviour that's currently documented?
• Does this change require new pages or sections of documentation?
• Who does this need to be documented for?
• Associated documentation pull request(s): ___ or documentation issue ___

Additional Notes:

Any additional information that you think would be helpful when reviewing this
PR.

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora/8-x-committers

[jordandukart]

Oof, nice catch @simonhm. Commit cleans things up. Do you have a CLA with the Islandora Foundation, would be the only blocking thing from me accepting this PR.

[simonhm]

Oof, nice catch @simonhm. Commit cleans things up. Do you have a CLA with the Islandora Foundation, would be the only blocking thing from me accepting this PR.

Yes, I do @jordandukart
https://github.com/Islandora/islandora-community/wiki/Contributor-License-Agreements

Btw, nice new condition though. I'm thinking about a lot of possible cases to use this new condition.
Thanks!
Simon.

[jordandukart]

Will let those tests play out and merge / patch release it, thanks for the contribution!

[jordandukart]

Looks to be unrelated test fails on 9.4.

[whikloj]

Just here to agree with @jordandukart, it appears that something has changed in 9.4.x-dev that is causing our test configuration to be invalid. This PR is unrelated to the error and so I am 👍 to just merging this PR.
The follow-on issue is Islandora/documentation#2093

[rosiel]

merging at request of @whikloj and @jordandukart on Slack, since @simonhm 's change didn't cause the failing test.