Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated annotation 'context' with 'context_definitions' #925

Merged
merged 1 commit into from
Feb 1, 2023
Merged

Replace deprecated annotation 'context' with 'context_definitions' #925

merged 1 commit into from
Feb 1, 2023

Conversation

JojoVes
Copy link

@JojoVes JojoVes commented Jan 26, 2023

What does this Pull Request do?

Addresses a deprecation that was missed.

What's new?

Just an extension of the work done in #764.
The deprecated annotation resulted in the 'Node reference by node' Condition failing to work in an environment using Drupal 9.4.

How should this be tested?

The 'Node referenced by node' Condition should now work as expected.

Honestly with how minimal this is, a full test case seems a little over-the-top. However, #808 can be referenced for how to test the functionality of this Condition Plugin.

Additional Notes:

There was a cleanup done for this deprecation in #764 before the 'NodeReferencedByNode' condition was made, then the deprecated annotation must have just been missed in reviewing #808.

Interested parties

@Islandora/committers

…itions'

There was a cleanup done for this deprecation in #764
before the 'NodeReferencedByNode' condition was made, then the deprecated annotation must have
just been missed in reviewing #808.
@seth-shaw-asu seth-shaw-asu merged commit c36f7d9 into Islandora:2.x Feb 1, 2023
rosiel pushed a commit to rosiel/islandora that referenced this pull request Feb 22, 2023
…itions' (Islandora#925)

There was a cleanup done for this deprecation in Islandora#764
before the 'NodeReferencedByNode' condition was made, then the deprecated annotation must have
just been missed in reviewing Islandora#808.
rosiel pushed a commit that referenced this pull request Jul 6, 2023
…itions' (#925)

There was a cleanup done for this deprecation in #764
before the 'NodeReferencedByNode' condition was made, then the deprecated annotation must have
just been missed in reviewing #808.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants