Fix the override facets soft-limit javascript

[simonhm]

GitHub Issue: (link)
Islandora/documentation#2100

• Other Relevant Links (Google Groups discussion, related pull requests,
  Release pull requests, etc.)

What does this Pull Request do?

This removes the override javascript that was causing problems executing the soft-limits.js code from the core facets module to address Islandora/documentation#2100

A brief description of what the intended result of the PR will be and/or what
problem it solves.

What's new?

A in-depth description of the changes made by this PR. Technical details and
possible side effects.

• Changes x feature to such that y
• Added x
• Removed y
• Does this change add any new dependencies?
• Does this change require any other modifications to be made to the repository
  (i.e. Regeneration activity, etc.)?
• Could this change impact execution of existing code?

How should this be tested?

To test, perform a search on a site that will give you at least 3 different facet values for a facet that uses a "List of links" configuration and has a value set for "Soft limit" ( The description for this "Limit the number of displayed facets via JavaScript." ) to limit facets at 3.

When the code works correctly, there should be no console errors relating to that soft-limits.js. Also, the facet that was limited will now only display the top 3 facet values and a link to "Show more".

Documentation Status

• Does this change existing behaviour that's currently documented?
• Does this change require new pages or sections of documentation?
• Who does this need to be documented for?
• Associated documentation pull request(s): ___ or documentation issue ___

Additional Notes:

Any additional information that you think would be helpful when reviewing this
PR.

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora/committers

[simonhm]

@wgilling
I don't know why you've added the code changed for IIIFManifest.php in your PR which is causing your patch fail.
So I've just created this PR so we can easily apply the patch for our sites.
Thanks!
Simon.

[wgilling]

I am closing the duplicate issue that had merge conflicts -- #870

If I am absolutely needed for help with testing, please let me know. I have limited time these days.

[simonhm]

I removed more code overriding core facets.
Those ones are causing some errors in Recent Logs:

Notice: Undefined index: soft_limit_settings in islandora_advanced_search_preprocess_facets_item_list() (line 163 of /var/www/html/drupal/web/modules/contrib/islandora/modules/islandora_advanced_search/islandora_advanced_search.module) ...
Simon.