Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Can't load mirador from local. #26

Closed
rosiel opened this issue Jun 23, 2023 · 2 comments
Closed

[BUG] Can't load mirador from local. #26

rosiel opened this issue Jun 23, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@rosiel
Copy link
Member

rosiel commented Jun 23, 2023

What steps does it take to reproduce the issue?

  • Set Config > Media > Mirador settings to load mirador from "Local library".
  • Place a copy of main.js in web/libraries/mirador/dist (created by running npm run webpack in the mirador-integration repo
  • Load a page that loads mirador

What happens?

The mirador library is loaded from roblib.github.io, as seen in the Network tab of a Firefox Inspector pane.

  • To whom does it occur (anonymous visitor, editor, administrator)?
    Everyone, I presume

  • What did you expect to happen?
    It would load from "local library"

Which version of Islandora are you using?
modern

Any related open or closed issues to this bug report?

Screenshots:

@rosiel rosiel added the bug Something isn't working label Jun 23, 2023
@wgilling
Copy link
Contributor

At the tech call, Seth et.al. suggested that the reason this is happening is due to the mirador coming from roblib being hard-coded somewhere... and that that issue would obviously be something that would be a blocker for the mirador work @alxp has been working on.

@alxp
Copy link
Contributor

alxp commented Jul 15, 2023

This seems to be due to two things:

  1. It's confusing where to actually put Mirador as a local library and what it should be called.
    1. The libraries alter hook was not unsetting the remote location. In older versions of Drupal, it seemed to be loading the library from the last array entry in $libraries['mirador']['js'], but in my Drupal 10 this isn't working.

PR to come.

alxp added a commit that referenced this issue Jul 16, 2023
rosiel added a commit that referenced this issue Aug 9, 2023
Issue #26: Fix 'Use local library' option.
@rosiel rosiel closed this as completed Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants