[actor shutdown] cell state bitmask fix #76
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When an actor shuts down, the state bitmask in the
ActorCell
is flipped from theContext
object when a shutdown is requested. Previously this was only set within the executor.Motivation
Part of #29
There is an asynchronous delay between an actor signaling it is shutting down to when the executor sets the state. This is because the request travels through the runtime manager and then back to the executor via async channel communications.
What is described above introduces a window where an actor has signaled shutdown and continues to receive messages. By setting the shutdown flag directly within the actor (as well as within the executor), messages processing by the actor will stop immediately.
Test Plan
Shutdown testing will be covered in the broader actor shutdown effort.