Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tutorial 6 code #477

Merged
merged 3 commits into from
May 26, 2022
Merged

Conversation

razetime
Copy link
Contributor

PR Checklist

If you are contributing to Javis.jl, please make sure you are able to check off each item on this list:

  • Did I update CHANGELOG.md with whatever changes/features I added with this PR?
  • Did I make sure to only change the part of the file where I introduced a new change/feature?
  • Did I cover all corner cases to be close to 100% test coverage (if applicable)?
  • Did I properly add Javis dependencies to the Project.toml + set an upper bound of the dependency (if applicable)?
  • Did I properly add test dependencies to the test directory (if applicable)?
  • Did I check relevant tutorials that may be affected by changes in this PR?
  • Did I clearly articulate why this PR was made the way it was and how it was made?

Link to relevant issue(s)
Closes #476

The function info_box was changed to support a keyword argument.

@codecov-commenter
Copy link

Codecov Report

Merging #477 (6a08113) into main (91ded55) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #477      +/-   ##
==========================================
- Coverage   96.41%   96.40%   -0.02%     
==========================================
  Files          35       35              
  Lines        1618     1613       -5     
==========================================
- Hits         1560     1555       -5     
  Misses         58       58              
Impacted Files Coverage Δ
src/Javis.jl 96.80% <0.00%> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91ded55...6a08113. Read the comment docs.

@Wikunia
Copy link
Member

Wikunia commented May 26, 2022

Thanks for the fix @razetime and sorry for the late merge.

@Wikunia Wikunia merged commit 9ecec81 into JuliaAnimators:main May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Tutorial 6 code issue
3 participants