Add keys to evalscript

[aviks]

evalscript should take a keys argument, according to https://redis.io/docs/latest/commands/eval/

[aviks]

The existing code/tests worked by concatenating keys and args, but looking at the redis docs, as well as the ruby driver, I would have expected that keys and args would be two separate arguments.

[tanmaykm]

Yes, this looks like a valid fix to evalscript.

You probably meant the PR title to say evalscript instead of evalsha? Because evalsha already seems to be accepting keys and args separately.

Also wondering if we should use @redisfunction for evalscript.

[aviks]

I realised this would be breaking unless we support the old behaviour as well.

[tanmaykm]

I realised this would be breaking unless we support the old behaviour as well.

True. Maybe we add a @redisfunction for evalscript and have the old method signature mapped to it with @deprecate?

[tanmaykm]

Maybe we add a @redisfunction for evalscript

On second thoughts, maybe we shouldn't do @redisfunction for that because it then needs to be named eval to match the redis command, and it will clash with Base.eval.

[tanmaykm]

I guess we can merge this and go for a major version bump as discussed in #110 (comment) ? Maybe I'll merge this in a bit.

I also think we should allow evalscript in PipelineConnection and TransactionConnection. Will add a separate PR for that.