Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure unique column names in query result by default #253

Closed
quinnj opened this issue Aug 12, 2021 · 0 comments · Fixed by #254
Closed

Ensure unique column names in query result by default #253

quinnj opened this issue Aug 12, 2021 · 0 comments · Fixed by #254

Comments

@quinnj
Copy link
Member

quinnj commented Aug 12, 2021

See discussion here: https://discourse.julialang.org/t/sqlite-query-with-duplicate-column-names-dataframe/64518
quinnj added a commit that referenced this issue Aug 12, 2021
@quinnj
By default, make query column names unique
3e6fc3a 
Fixes #253. Most data formats have requirements around column name
uniqueness, including DataFrames.jl. The proposed changes here ensure
query result columns are unique by default, while still allowing column
names to be duplicated if they pass `allowduplicates=true` to
`DBInterface.execute`.
@quinnj quinnj mentioned this issue Aug 12, 2021
Merged
quinnj added a commit that referenced this issue Aug 12, 2021
@quinnj @bkamins
By default, make query column names unique (#254)
dd14546 
* By default, make query column names unique

Fixes #253. Most data formats have requirements around column name
uniqueness, including DataFrames.jl. The proposed changes here ensure
query result columns are unique by default, while still allowing column
names to be duplicated if they pass `allowduplicates=true` to
`DBInterface.execute`.

* Update test/runtests.jl

Co-authored-by: Bogumił Kamiński <bkamins@sgh.waw.pl>

Co-authored-by: Bogumił Kamiński <bkamins@sgh.waw.pl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

By default, make query column names unique JuliaDatabases/SQLite.jl
1 participant
@quinnj