Use Table column names in load! #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-b1
commented
Aug 21, 2020
| @@ -291,11 +291,27 @@ row2 = first(r) | |||
| @test DBInterface.lastrowid(r) == 3 | |||
|
|
|||
| r = DBInterface.execute(db, "SELECT * FROM T") |> columntable | |||
| SQLite.load!(nothing, Tables.rows(r), db, "T2", "T2", true) | |||
| SQLite.load!(nothing, Tables.rows(r), db, "T2", "T2", SQLite.tableinfo(db, "T2")) | |||
There was a problem hiding this comment.
This is an internal interface, so I think fine to change this test?
Codecov Report
@@ Coverage Diff @@
## master #217 +/- ##
==========================================
- Coverage 81.53% 76.83% -4.70%
==========================================
Files 5 5
Lines 444 505 +61
==========================================
+ Hits 362 388 +26
- Misses 82 117 +35
Continue to review full report at Codecov.
|
|
Looks great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #216