Support DBInterface.execute(f, stmt) method #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
called by DBInterface.execute(f, stmt)
|
The DBInterface requirements would have to be bumped to the next version (2.4?) for these tests to pass. |
Codecov Report
@@ Coverage Diff @@
## master #226 +/- ##
==========================================
+ Coverage 82.52% 82.61% +0.09%
==========================================
Files 5 5
Lines 578 581 +3
==========================================
+ Hits 477 480 +3
Misses 101 101
Continue to review full report at Codecov.
|
|
Dunno why documentation check is failing (for some reason it cannot find DBInterface.jl v2.4.0) |
|
@quinnj now the CI looks good for this PR |
quinnj
approved these changes
Jan 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR implements adds
DBInterface.close!(::Query)required byDBInterface.execute(f, stmt)introduced in JuliaDatabases/DBInterface.jl#35 and adds tests to make sure thatDBIntreface.execute(f, ...)methods work.