Ensure bit integer values are returned as Int64 #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #207. The issue here was in our translation from sqlite type to Julia type, we were using `Int`, though in the `sqlitevalue` function that actually retrieved the value from the database, we used `sqlite3_column_int64`. This change just ensures that even in 32-bit systems, we'll return values as Int64, avoiding issues like the `RANDOM()` sqlite function, which returns an Int64 value.
Codecov Report
@@ Coverage Diff @@
## master #234 +/- ##
=======================================
Coverage 83.30% 83.30%
=======================================
Files 5 5
Lines 605 605
=======================================
Hits 504 504
Misses 101 101
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #207. The issue
here was in our translation from sqlite type to Julia type, we were
using
Int, though in thesqlitevaluefunction that actuallyretrieved the value from the database, we used
sqlite3_column_int64.This change just ensures that even in 32-bit systems, we'll return
values as Int64, avoiding issues like the
RANDOM()sqlite function,which returns an Int64 value.