Ensure rows are only valid while currently being iterated #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #251 amongst other issues. This PR makes `SQLite.Row` explicitly error when values are attempted to be accessed and it's not the currently iterated row. It borrows the idea from the MySQL.jl package, which as a similar "sync" of row numbers between the `Row` and `Query` objects.
This was referenced Oct 20, 2021
Codecov Report
@@ Coverage Diff @@
## master #262 +/- ##
==========================================
+ Coverage 85.05% 85.14% +0.08%
==========================================
Files 5 5
Lines 676 680 +4
==========================================
+ Hits 575 579 +4
Misses 101 101
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #251 amongst other issues. This PR makes
SQLite.Rowexplicitlyerror when values are attempted to be accessed and it's not the
currently iterated row. It borrows the idea from the MySQL.jl package,
which as a similar "sync" of row numbers between the
RowandQueryobjects.