Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert DB input to String to try and avoid any weirdness #266

Merged
merged 1 commit into from
Oct 23, 2021
Merged

Conversation

quinnj
Copy link
Member

@quinnj quinnj commented Oct 23, 2021

As reported in #265, perhaps the sqlite library doesn't like SubStrings
sometimes. It's a pretty easy fix to just convert to String before
passing to sqlite_open.

As reported in #265, perhaps the sqlite library doesn't like SubStrings
sometimes. It's a pretty easy fix to just convert to String before
passing to sqlite_open.
@codecov
Copy link

codecov bot commented Oct 23, 2021

Codecov Report

Merging #266 (2561188) into master (b20aafa) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #266   +/-   ##
=======================================
  Coverage   85.27%   85.27%           
=======================================
  Files           5        5           
  Lines         686      686           
=======================================
  Hits          585      585           
  Misses        101      101           
Impacted Files Coverage Δ
src/SQLite.jl 95.95% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b20aafa...2561188. Read the comment docs.

@quinnj quinnj merged commit 735d3fe into master Oct 23, 2021
@quinnj quinnj deleted the jq/265 branch October 23, 2021 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant