Allow sqldeserialize to return non-T to allow value/schema mismatch #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #244. Last time we refactored SQLite.Query, we took out any strict schema enforcement, mainly by defining the `Tales.schema` of `SQLite.Query` to be `nothing`, thus allowing sinks to "discover" the schema dynamically, which better fits the sqlite data type model. As reported in #244, however, we missed a case where we pass in the declared column's type to `sqlitevalue` and then `sqldeserialize` was being forced to assert that what it deserialized was a value of that type. That isn't generally possible, since the declared sqlite types are such a small subset of what we'll technically serialize/deserialize with custom Julia values. By removing the type assertion, we allow sqldeserialize to do its job and sqlitevalue to return whatever gets deserialized.
Codecov Report
@@ Coverage Diff @@
## master #267 +/- ##
==========================================
+ Coverage 85.27% 85.42% +0.14%
==========================================
Files 5 5
Lines 686 686
==========================================
+ Hits 585 586 +1
+ Misses 101 100 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #244. Last time we refactored SQLite.Query, we took out any strict
schema enforcement, mainly by defining the
Tales.schemaofSQLite.Queryto benothing, thus allowing sinks to "discover" theschema dynamically, which better fits the sqlite data type model. As
reported in #244, however, we missed a case where we pass in the
declared column's type to
sqlitevalueand thensqldeserializewasbeing forced to assert that what it deserialized was a value of that
type. That isn't generally possible, since the declared sqlite types are
such a small subset of what we'll technically serialize/deserialize with
custom Julia values. By removing the type assertion, we allow
sqldeserialize to do its job and sqlitevalue to return whatever gets
deserialized.