Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Julia < 1.3 #288

Merged
merged 1 commit into from
Apr 14, 2022
Merged

Drop Julia < 1.3 #288

merged 1 commit into from
Apr 14, 2022

Conversation

jeremiahpslewis
Copy link
Contributor

@jeremiahpslewis jeremiahpslewis commented Mar 6, 2022 •
edited
Loading

Resolve #287

@codecov
Copy link

codecov bot commented Mar 6, 2022 •
edited
Loading

Codecov Report

Merging #288 (1a5bb54) into master (d99fdfb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #288   +/-   ##
=======================================
  Coverage   86.01%   86.01%           
=======================================
  Files           5        5           
  Lines         708      708           
=======================================
  Hits          609      609           
  Misses         99       99
Impacted Files Coverage Δ
src/consts.jl 88.88% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d99fdfb...1a5bb54. Read the comment docs.

quinnj
quinnj approved these changes Apr 14, 2022
View reviewed changes
Copy link
Member

@quinnj quinnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jeremiahpslewis! Sorry for the slow review/merge!

@quinnj quinnj merged commit 294cb24 into JuliaDatabases:master Apr 14, 2022
@jeremiahpslewis jeremiahpslewis deleted the jpsl/1.3-plus branch April 14, 2022 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quinnj quinnj quinnj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop BinaryProvider.jl
2 participants
@jeremiahpslewis @quinnj