handle permutedims rrule with ZeroTangent #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcabbott
reviewed
Oct 24, 2022
| @@ -143,18 +143,21 @@ end | |||
| function rrule(::typeof(permutedims), x::AbstractVector) | |||
| project = ProjectTo(x) | |||
| permutedims_pullback_1(dy) = (NoTangent(), project(permutedims(unthunk(dy)))) | |||
| permutedims_pullback_1(::ZeroTangent) = (NoTangent(), ZeroTangent()) | |||
There was a problem hiding this comment.
IDK why there are several Zeros, but perhaps if doing this it may as well accept all of them:
Suggested change
| permutedims_pullback_1(::ZeroTangent) = (NoTangent(), ZeroTangent()) | |
| permutedims_pullback_1(z::AbstractZero) = (NoTangent(), z) |
There was a problem hiding this comment.
IDK either, but I follow how CR.jl previously do.
There was a problem hiding this comment.
Instances of the wider pattern, which I didn't write, include:
There was a problem hiding this comment.
Oh, then should I update this PR, or just leave as it is?
mcabbott
approved these changes
Oct 25, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.