Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support IrrationalConstants 0.2 #91

Merged
merged 1 commit into from
Feb 22, 2023
Merged

Conversation

devmotion
Copy link
Member

IrrationalConstants 0.2 changes the type of the irrational constants to fix a type piracy issue: JuliaMath/IrrationalConstants.jl#19 This change is breaking but should not cause any problems in DiffRules.

@codecov-commenter
Copy link

Codecov Report

Base: 97.31% // Head: 97.86% // Increases project coverage by +0.54% 🎉

Coverage data is based on head (ee06ba4) compared to base (9030629).
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #91      +/-   ##
==========================================
+ Coverage   97.31%   97.86%   +0.54%     
==========================================
  Files           3        3              
  Lines         186      187       +1     
==========================================
+ Hits          181      183       +2     
+ Misses          5        4       -1     
Impacted Files Coverage Δ
src/api.jl 88.23% <0.00%> (+3.38%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@devmotion
Copy link
Member Author

devmotion commented Feb 21, 2023

Test failures are unrelated and exist also on the master branch.

Not tested, new release of SpecialFunctions required first.

@devmotion devmotion merged commit 6576392 into master Feb 22, 2023
@devmotion devmotion deleted the dw/irrationalconstants branch February 22, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants