Compact show for ZeroBundle etc #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #136 +/- ##
==========================================
+ Coverage 49.00% 49.26% +0.26%
==========================================
Files 27 27
Lines 2655 2671 +16
==========================================
+ Hits 1301 1316 +15
- Misses 1354 1355 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Keno
added a commit
that referenced
this pull request
Apr 9, 2023
Keno
added a commit
that referenced
this pull request
Apr 9, 2023
Keno
added a commit
that referenced
this pull request
Apr 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #102
I should have done this ages ago.
When digesting IR I often copy pasted it into an editor and made this change via ctlr+f. So it's clearly a good idea.
A potentially contentious change is to overload the
showfor the types themselves, but I want nice stacktraces.Potentially, we could do this via TruncatedStacktraces.jl?