Fix getindex on CompositeBundle of a struct #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #153 +/- ##
==========================================
+ Coverage 51.48% 51.83% +0.35%
==========================================
Files 27 27
Lines 2694 2693 -1
==========================================
+ Hits 1387 1396 +9
+ Misses 1307 1297 -10
☔ View full report in Codecov by Sentry. |
oxinabox
force-pushed
the
ox/tangentforward
branch
from
b70a789
to
b845365
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #152
It is still constructed "wrong" but we fix it in the
getindexNot sure if we should have
getindex(::CompositeBundle, ::TaylorTangentIndex)callingpartial(::CompositeBundle, ::Int)(this PR)
or the other way around.
Which is more canonical?
We can always change later.