Don't insert truncation within phi blocks #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keno
reviewed
Jun 14, 2023
oxinabox
commented
Jun 14, 2023
|
Idea looks right. Algorithm for check the bb needs to be updated as suggested, otherwise looks fine. |
Keno
reviewed
Jun 14, 2023
|
Elliot bisected CI being broken to JuliaLang/julia@9d839f9 |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #162 +/- ##
==========================================
+ Coverage 51.68% 52.40% +0.71%
==========================================
Files 27 27
Lines 2693 2704 +11
==========================================
+ Hits 1392 1417 +25
+ Misses 1301 1287 -14
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This goes along with making diffractor follow this rule:
JuliaLang/julia#50158
The hard bit of this PR was writing the test. But now I know kinda how phi-nodes work.