Pass ssa instead of stmt to visit_custom!()
#169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a good change. There are several tests which hack around this lack. They should be updated to not work around it. |
|
Hmm this did not fix those tests. No matter, I will follow up on that later. |
We need to pass the SSA index, rather than the statement itself so that `visit_custom!()` can inspect the type of the statement under visitation. This is more consistent with the `transform!()` API as well.
oxinabox
force-pushed
the
sf/ssa_insteadof_stmt
branch
from
60a99fe
to
4076b60
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #169 +/- ##
==========================================
+ Coverage 22.96% 22.99% +0.02%
==========================================
Files 27 27
Lines 2661 2662 +1
==========================================
+ Hits 611 612 +1
Misses 2050 2050
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to pass the SSA index, rather than the statement itself so that
visit_custom!()can inspect the type of the statement under visitation.This is more consistent with the
transform!()API as well.