Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark broken reverse mode tests broken #171

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Conversation

oxinabox
Copy link
Member

Work around #170
This marks over 70 tests broken.
Once that is resolved can find and replace to remove the markers. (or revert this commit)
I will merge this ASAP so can merge other stuff

@oxinabox
Copy link
Member Author

I do not get the failure related to effect-free on my local machine with yesterday's nightly.
Rebuidling my nightly now to investigate

Copy link
Member

@aviatesk aviatesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine to merge this quickly since it looks like we can remove these broken annotations easily using a grep replacement once we resolve the issue.

@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Patch coverage has no change and project coverage change: -29.45 ⚠️

Comparison is base (b23337a) 52.40% compared to head (d820497) 22.96%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #171       +/-   ##
===========================================
- Coverage   52.40%   22.96%   -29.45%     
===========================================
  Files          27       27               
  Lines        2704     2661       -43     
===========================================
- Hits         1417      611      -806     
- Misses       1287     2050      +763     
Impacted Files Coverage Δ
src/stage1/recurse.jl 12.30% <0.00%> (-84.11%) ⬇️

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@oxinabox oxinabox merged commit 53a3ded into main Jun 28, 2023
4 of 6 checks passed
@oscardssmith oscardssmith deleted the ox/broken_reverse_tests branch June 28, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants