Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle tuples with types in them #236

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Handle tuples with types in them #236

wants to merge 2 commits into from

Conversation

oxinabox
Copy link
Member

Diffractor was having a bit of a sad because (Int,) has type Tuple{DataType}
but the primal B has type Tuple{Type{Int}},
and while they are logically the same apparently dispatch does not like that.

The solution right now in this PR is to throw away that extra info we have about B and normalize it to just Typle{DataType}.
idk if it is best, I am open to other ideas.

@oxinabox oxinabox requested a review from Keno October 17, 2023 08:18
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (7be0a92) 56.17% compared to head (2a9a3f7) 56.19%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #236      +/-   ##
==========================================
+ Coverage   56.17%   56.19%   +0.01%     
==========================================
  Files          28       28              
  Lines        2848     2849       +1     
==========================================
+ Hits         1600     1601       +1     
  Misses       1248     1248              
Files Coverage Δ
src/stage1/recurse_fwd.jl 94.91% <100.00%> (+0.08%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oxinabox
Copy link
Member Author

oxinabox commented Nov 3, 2023

@Keno could you give this a review, and see if you think of a better way?

@oxinabox oxinabox mentioned this pull request Dec 29, 2023
3 tasks
@staticfloat
Copy link
Collaborator

@Keno review please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants