Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dx methods #77

Merged
merged 3 commits into from
Jul 8, 2022
Merged

add dx methods #77

merged 3 commits into from
Jul 8, 2022

Conversation

oscardssmith
Copy link
Member

Before

const bwd = Diffractor.PrimeDerivativeBack
bwd(bwd(x->5))

failed.

@Keno
Copy link
Collaborator

Keno commented Jun 29, 2022

Needs tests

@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2022

Codecov Report

Merging #77 (3dbc84e) into main (be3b62d) will decrease coverage by 0.04%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main      #77      +/-   ##
==========================================
- Coverage   52.67%   52.62%   -0.05%     
==========================================
  Files          21       21              
  Lines        2170     2172       +2     
==========================================
  Hits         1143     1143              
- Misses       1027     1029       +2     
Impacted Files Coverage Δ
src/interface.jl 70.90% <50.00%> (-0.79%) ⬇️
src/stage1/forward.jl 76.87% <0.00%> (-1.37%) ⬇️
src/tangent.jl 34.04% <0.00%> (+1.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be3b62d...3dbc84e. Read the comment docs.

@oscardssmith
Copy link
Member Author

this is ready to merge.

@Keno Keno merged commit 82096ee into JuliaDiff:main Jul 8, 2022
@oscardssmith oscardssmith deleted the patch-1 branch July 11, 2022 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants