Use broadcasting rules from ChainRules #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 1, 2022
Codecov Report
@@ Coverage Diff @@
## main #89 +/- ##
==========================================
+ Coverage 51.69% 55.54% +3.84%
==========================================
Files 21 21
Lines 2124 2157 +33
==========================================
+ Hits 1098 1198 +100
+ Misses 1026 959 -67
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
This mostly looks really good. |
oscardssmith
approved these changes
Sep 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the reverse-mode broadcasting definitions here, in favour of the ones from ChainRules.
To make tests work, it also adjusts a few other rules, to add
unthunk, or handle trivial cases, or to ensurezero(x)is only called on arrays of numbers. Not all were required by the tests here, some were for testing some Flux models (and some are in JuliaDiff/ChainRules.jl#673). Test from #82 passes.All theMost of the second order tests fail. They fail before this PR, too.Built on top of #88, have not tested whether it would work without that.(rebased)Closes #53