Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JLD2 extension #354

Merged
merged 6 commits into from
Apr 1, 2024
Merged

Add JLD2 extension #354

merged 6 commits into from
Apr 1, 2024

Conversation

PerezHz
Copy link
Contributor

@PerezHz PerezHz commented Mar 31, 2024

This PR adds functionality currently hosted in NEOs, but which should be moved over here for at least two reasons: avoiding type-piracy 🏴‍☠️ (see PerezHz/NEOs.jl#62), as well as enabling users in general to store TaylorN polynomials in .jld2 files.

Acknowledgments: original TaylorNSerialization implementation is due to @LuEdRaMo.

@coveralls
Copy link

coveralls commented Mar 31, 2024

Coverage Status

coverage: 96.959% (+0.001%) from 96.958%
when pulling 8eaf11e on PerezHz:jp/jld2ext
into a79b022 on JuliaDiff:master.

Copy link
Member

@lbenet lbenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let me know if this is ready to be merged.

Thanks a lot!

@PerezHz
Copy link
Contributor Author

PerezHz commented Apr 1, 2024

@lbenet just pushed a commit removing a leftover comment, but this ready to be merged 👍

Copy link
Member

@lbenet lbenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Merging

@lbenet lbenet merged commit 87116db into JuliaDiff:master Apr 1, 2024
11 of 12 checks passed
@PerezHz PerezHz deleted the jp/jld2ext branch April 1, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants