Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI on julia 1.0 #14

Merged
merged 3 commits into from
Nov 8, 2018
Merged

CI on julia 1.0 #14

merged 3 commits into from
Nov 8, 2018

Conversation

visr
Copy link
Contributor

@visr visr commented Sep 22, 2018

The master branch was already working on julia 1.0, this just proves it :)
Would be great if a new release could be tagged, because currently it's not installable on 1.0.

The master branch was already working on julia 1.0, this just proves it :)
Would be great if a new release could be tagged, because currently it's not installable on 1.0.
@oxinabox
Copy link
Member

oxinabox commented Sep 23, 2018

Thanks,
I'll take a look at this in the next few days. (Ping me if I don't)

I really thought this was broken.
In particular the suggested near spellings I thought was borked because lev-sort moved to interactive utils.

Maybe that isn't tested...

README.md Outdated Show resolved Hide resolved
@visr
Copy link
Contributor Author

visr commented Nov 8, 2018

@oxinabox ping :)

In particular the suggested near spellings I thought was borked because lev-sort moved to interactive utils. Maybe that isn't tested...

It is now, seems it was working fine.

@oxinabox
Copy link
Member

oxinabox commented Nov 8, 2018

Ok fair enough, LGTM
Thanks

@oxinabox oxinabox merged commit 3981561 into JuliaGraphics:master Nov 8, 2018
@visr visr deleted the ci branch November 8, 2018 17:12
@visr
Copy link
Contributor Author

visr commented Nov 8, 2018

Great, thanks. Could you perhaps also tag a release? Currently not installable on 1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants