Align meaning for effects and IR flags #50313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a longstanding todo where the IR_FLAG_EFFECT_FREE flag actually required both :effect_free and :nothrow. After this PR, it is equivalent to :effect_free only. The mismatch in meaning here caused #50311. `Symbol(::String)` is :effect_free, but not :nothrow. As a result, setting IR_FLAG_EFFECT_FREE on it was not legal. Later, irinterp did discover that it was nothrow and set IR_FLAG_NOTHROW, but did not have sufficient information to know that it was also :effect_free, so it could not set that flag. With this PR, IR_FLAG_EFFECT_FREE is set early in inference, so once irinterp discovers IR_FLAG_NOTHROW, the call becomes DCE-eligible as desired. Fixes #50311.
Keno
added
the
compiler:optimizer
| @@ -510,9 +510,11 @@ end) | |||
|
|
|||
| function Symbol(s::String) | |||
| @_foldable_meta | |||
| @noinline | |||
There was a problem hiding this comment.
There's rarely a good reason to inline a ccall and in this case if you inline it, you lose the ability to consteval it, because the effect flags only attach to the function as a whole.
aviatesk
reviewed
Jun 28, 2023
| @@ -1650,7 +1651,7 @@ function inline_const_if_inlineable!(inst::Instruction) | |||
| inst[:inst] = quoted(rt.val) | |||
| return true | |||
| end | |||
| inst[:flag] |= IR_FLAG_EFFECT_FREE | |||
| inst[:flag] |= IR_FLAG_EFFECT_FREE | IR_FLAG_NOTHROW | |||
There was a problem hiding this comment.
Maybe better to define
const IR_FLAG_REMOVAL_IF_UNUSED.
oxinabox
added a commit
to JuliaDiff/Diffractor.jl
that referenced
this pull request
Jun 28, 2023
remove noneffectfree per JuliaLang/julia#50313
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a longstanding todo where the IR_FLAG_EFFECT_FREE flag actually required both :effect_free and :nothrow. After this PR, it is equivalent to :effect_free only. The mismatch in meaning here caused #50311.
Symbol(::String)is :effect_free, but not :nothrow. As a result, setting IR_FLAG_EFFECT_FREE on it was not legal. Later, irinterp did discover that it was nothrow and set IR_FLAG_NOTHROW, but did not have sufficient information to know that it was also :effect_free, so it could not set that flag. With this PR, IR_FLAG_EFFECT_FREE is set early in inference, so once irinterp discovers IR_FLAG_NOTHROW, the call becomes DCE-eligible as desired. Fixes #50311.