Improve Mocking debugging #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #128 +/- ##
==========================================
+ Coverage 87.41% 93.33% +5.92%
==========================================
Files 6 7 +1
Lines 143 165 +22
==========================================
+ Hits 125 154 +29
+ Misses 18 11 -7 ☔ View full report in Codecov by Sentry. |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing some debugging with ScopedValues support I found the
PatchEnvdebug flag was now inadequate as running a task declared before theapplyscope results in no debugging information for that@mockcall site. I've instead overhauled the intercepted logging messages for Mocking to be debug messages that are displayed independently from the patch environment. This does result in way more logging messages but overall I think this is more useful.Additionally, I've added in details as to which
@mockcall site was intercepted by displaying the location of the call site and it's containing module.As this is a breaking change I'll include this in the upcoming 0.8 release.