Support Compat@4 #98
Merged
Support Compat@4 #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #98 +/- ##
==========================================
- Coverage 84.09% 83.46% -0.63%
==========================================
Files 6 6
Lines 132 127 -5
==========================================
- Hits 111 106 -5
Misses 21 21
Continue to review full report at Codecov.
|
This was referenced May 23, 2022
|
Can we please have a new release including this PR? This package is still holding back Compat. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Compat >= 4. In 4.0.0 many dependencies were removed by dropping support for Julia < 1.6.
It seems CompatHelper does not create PRs for Compat@4 currently (same happened in e.g. CRC). I wonder if the problem is that CompatHelper pulls in Compat@3, possibly due to its dependency on Mocking. So possibly updating Mocking will resolve the issue.