Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build!: drop support for node 16 #575

Merged
merged 2 commits into from
Oct 24, 2023
Merged

build!: drop support for node 16 #575

merged 2 commits into from
Oct 24, 2023

Conversation

JustinBeckwith
Copy link
Owner

@JustinBeckwith JustinBeckwith commented Oct 24, 2023

BREAKING CHANGE: This module now requires node.js 18 and up. It includes a variety of related changes:

  • Migrate from gts to xo for linting and code formatting
  • Upgrade multiple deps to the latest version that were blocked on node 16
  • Drop the codecov dependency and move to the github action
  • Update the tsconfig to target Node16 for the module strategy

It's entirely possible this change didn't break anything for most users, but it's also possible it did.

if (flags.urlRewriteSearch && flags.urlRewriteReplace) {
options.urlRewriteExpressions = [
{
pattern: new RegExp(flags.urlRewriteSearch),

Check failure

Code scanning / CodeQL

Regular expression injection High

This regular expression is constructed from a
command-line argument
.
res.end(JSON.stringify(err));
function return404(response: http.ServerResponse, error: Error) {
response.writeHead(404);
response.end(JSON.stringify(error));

Check warning

Code scanning / CodeQL

Exception text reinterpreted as HTML Medium

Exception text
is reinterpreted as HTML without escaping meta-characters.
response.statusCode = 301;
response.setHeader('Content-Type', 'text/html; charset=UTF-8');
response.setHeader('Content-Length', Buffer.byteLength(doc));
response.setHeader('Location', request.url + '/');

Check warning

Code scanning / CodeQL

Server-side URL redirect Medium

Untrusted URL redirection depends on a
user-provided value
.
res.end(JSON.stringify(err));
function return404(response: http.ServerResponse, error: Error) {
response.writeHead(404);
response.end(JSON.stringify(error));

Check warning

Code scanning / CodeQL

Information exposure through a stack trace Medium

This information exposed to the user depends on
stack trace information
.
This information exposed to the user depends on
stack trace information
.
This information exposed to the user depends on
stack trace information
.
@JustinBeckwith JustinBeckwith merged commit 351a7c9 into main Oct 24, 2023
7 of 8 checks passed
@JustinBeckwith JustinBeckwith deleted the twenty branch October 24, 2023 20:52
@github-actions
Copy link

🎉 This PR is included in version 6.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

This was referenced Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant