Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fences are always placed as multiparts #13

Open
coderbot16 opened this issue Mar 19, 2020 · 2 comments
Open

Fences are always placed as multiparts #13

coderbot16 opened this issue Mar 19, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@coderbot16
Copy link

Even when just placing down a fence in an empty block space, it's placed as a multipart container. This should only happen when something already exists in the block space!
@Juuxel Juuxel added the bug Something isn't working label Mar 19, 2020
@Loriborn
Copy link

This is the same issue I had mentioned in #8 and if fixed would make #11 also unnecessary as regularly placed fences (ie. not multiblock) supporting leads would be expected behavior.

@Juuxel
Copy link
Owner

Juuxel commented Mar 20, 2020

Yeah, the fence placement code needs some cleanup. #11 is still something I'd like to add at some point, though.

@rysson rysson mentioned this issue Apr 23, 2020
Open
Juuxel added a commit that referenced this issue Jun 29, 2020
@Juuxel
Fix fences always being multiparts
ed3ed82 
Fixes #13.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Loriborn @Juuxel @coderbot16