Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The size of a sidebar widget won't be saved and loaded #155

Closed
tlaemmlein opened this issue Feb 1, 2021 · 3 comments
Closed

The size of a sidebar widget won't be saved and loaded #155

tlaemmlein opened this issue Feb 1, 2021 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@tlaemmlein
Copy link

Code basis: 1.2.1 -> (2021-01-28)
Steps to reproduce:

  • Enable the auto-hide feature
  • Pin a widget into the sidebar
  • Show the sidebar widget
  • Change the size
  • Hide the sidebar widget and show it again
  • Oberserve that the size is still default
  • Wish/Expectation: The current size of the sidebar widegt should be saved and loaded
  • Compare this to the dock/undock feature -> If you dock an widget the size will be laoded
    Here is an animation for better understanding:
    size_behaviour_of_sidebar_widget
@tlaemmlein
Copy link
Author

Here is an example which demonstrates the problem with an program editor:
example_of_not_stored_sidebar_window_size

@iamsergio iamsergio self-assigned this Feb 5, 2021
@iamsergio iamsergio added the bug Something isn't working label Feb 5, 2021
iamsergio added a commit that referenced this issue Feb 6, 2021
iamsergio added a commit that referenced this issue Feb 6, 2021
@tlaemmlein
Copy link
Author

@iamsergio Thanks, but please merge the changes into the 1.2 branch.

@tlaemmlein tlaemmlein changed the title The size of a sizebar widget won't be saved and loaded The size of a sidebar widget won't be saved and loaded Feb 8, 2021
@iamsergio
Copy link
Contributor

v1.3.0 and v1.2.1 were released. This change is included in v1.3.0. Branch 1.2 is now closed.

I'm not very fond of adding "unimplemented features" to the stable branch. Will rather just add pure bug fixes or any other critical issues, since now many projects are using stable, so things get a bit more strict.

On the upside, the delta to 1.3 is very small, so should be an easy and uneventful update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants